Move the declaration and description of options that configt handles into config.h #5874
Conversation
Although configt is not an ideal solution, I think it is best for it to do all of the parsing for its option in one place. As a side effect this adds the C and C++ language options to goto-analyzer.
martin-cs
requested review from
chrisr-diffblue,
hannes-steffenhagen-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
martin-cs
force-pushed
the
refactor/config-set-up
branch
from
175fdbb to
7a3d4bd
Compare
This should not change the functionality apart from: - goto-analyzer no longer parses Java options. They were ignored so this is an improvement. - The no-arch option is no longer supported or documented. It didn't work and was ignored so, again, an improvement. - The '--gcc' option is now described in the help documentation on all platforms.
martin-cs
force-pushed
the
refactor/config-set-up
branch
from
7a3d4bd to
42896e7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5874 +/- ##
========================================
Coverage 72.90% 72.90%
========================================
Files 1423 1423
Lines 154196 154159 -37
========================================
- Hits 112412 112397 -15
+ Misses 41784 41762 -22
Continue to review full report at Codecov.
|
|
The only failed test is diff coverage which I think drops because this is a net removal of (duplicated) code. I don't think this is a problem as such. |
|
@peterschrammel : |
This is a tidy up that should not have any real effect on the tools but makes the source clearer. It raises the issue that
--functionand--string-abstractionare handled byconfigtand by parsing intooptionst. I think that should be left for tidying up of the functionality ofconfigt(or even, you know, removing it all together).