introduce instructiont::return_value() #5863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
goto_instruction_return
branch
4 times, most recently
from
0919108 to
0716bfd
Compare
This mirrors the change in #5861 by replacing the use of code_returnt by directly returning the return value expression. The client code is simplified considerably.
kroening
force-pushed
the
goto_instruction_return
branch
from
0716bfd to
e0700db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5863 +/- ##
========================================
Coverage 72.89% 72.90%
========================================
Files 1423 1423
Lines 154229 154231 +2
========================================
+ Hits 112426 112441 +15
+ Misses 41803 41790 -13
Continue to review full report at Codecov.
|
kroening
requested review from
chrisr-diffblue,
hannes-steffenhagen-diffblue,
martin-cs,
peterschrammel,
romainbrenguier,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Feb 24, 2021
| const code_returnt &ret_expr = to_code_return(inst.code); | ||
| if(ret_expr.return_value().id() == ID_side_effect) | ||
| const auto &return_value = inst.return_value(); | ||
| if(return_value.id() == ID_side_effect) |
There was a problem hiding this comment.
Not for this PR: we need to re-consider whether "nondet" really should remain a "side effect." It'll eventually be the only side effect remaining in goto programs.
| @@ -2013,22 +2013,18 @@ void goto_checkt::goto_check( | |||
| } | |||
| else if(i.is_return()) | |||
| { | |||
| if(i.code.operands().size()==1) | |||
| check(i.return_value()); | |||
| // the return value invalidate any assertion | |||
There was a problem hiding this comment.
Nit pick: s/invalidate/invalidates/
peterschrammel
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the change in #5861 by replacing the use of
code_returntbydirectly returning the return value expression. The client code is
simplified considerably.