Skip to content

introduce instructiont::dead_symbol() #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Conversation

kroening
Copy link
Member

This mirrors the change in #5861 by replacing the use of code_deadt by
directly returning the symbol_exprt. The client code is simplified.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the goto_instruction_dead branch 2 times, most recently from f7e5ba6 to dc075cf Compare February 24, 2021 13:07
This mirrors the change in #5861 by replacing the use of code_deadt by
directly returning the symbol_exprt.  The client code is simplified.
@kroening kroening force-pushed the goto_instruction_dead branch from dc075cf to 9b549f4 Compare February 24, 2021 14:16
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #5862 (9b549f4) into develop (4daa686) will increase coverage by 0.00%.
The diff coverage is 93.08%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5862   +/-   ##
========================================
  Coverage    72.89%   72.89%           
========================================
  Files         1423     1423           
  Lines       154229   154242   +13     
========================================
+ Hits        112426   112440   +14     
+ Misses       41803    41802    -1     
Impacted Files Coverage Δ
src/analyses/global_may_alias.cpp 0.00% <0.00%> (ø)
src/analyses/goto_check.cpp 88.28% <ø> (ø)
src/goto-diff/change_impact.cpp 0.00% <ø> (ø)
.../goto-instrument/goto_instrument_parse_options.cpp 58.20% <ø> (ø)
...rc/goto-instrument/goto_instrument_parse_options.h 100.00% <ø> (ø)
src/goto-programs/goto_convert_class.h 87.30% <ø> (ø)
src/goto-diff/goto_diff_parse_options.cpp 58.67% <75.00%> (ø)
src/goto-programs/goto_program.h 89.36% <80.00%> (ø)
src/goto-analyzer/goto_analyzer_parse_options.cpp 73.25% <90.90%> (ø)
src/util/std_code.h 94.02% <90.90%> (+0.01%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c81ef...9b549f4. Read the comment docs.

@tautschnig tautschnig removed their assignment Feb 24, 2021
@kroening kroening merged commit 99741b3 into develop Feb 24, 2021
@kroening kroening deleted the goto_instruction_dead branch February 24, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants