Skip to content

Fix Makefile clean target failing to delete build artifact. #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

NlightNFotis
Copy link
Contributor

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Feb 22, 2021
@NlightNFotis NlightNFotis changed the title Fix Makefile clean target deleting the wrong file. Fix Makefile clean target failing to delete build artifact. Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #5853 (0f9bfa7) into develop (4d7158f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5853   +/-   ##
========================================
  Coverage    72.87%   72.88%           
========================================
  Files         1421     1421           
  Lines       154208   154262   +54     
========================================
+ Hits        112386   112434   +48     
- Misses       41822    41828    +6     
Impacted Files Coverage Δ
src/analyses/goto_check.cpp 88.28% <100.00%> (+0.02%) ⬆️
src/util/format_expr.cpp 85.77% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46de6f6...0f9bfa7. Read the comment docs.

@NlightNFotis NlightNFotis merged commit ddad3ee into diffblue:develop Feb 22, 2021
@NlightNFotis NlightNFotis deleted the fix_regression_makefile branch February 22, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants