Skip to content

[CI] Cleanup .github/ folder #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

NlightNFotis
Copy link
Contributor

This PR is removing some files that are no longer needed from the .github/ folder,
and it's rewriting the README.md file in that folder to more accurately represent
the current state of affairs.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Fotis Koutoulakis added 2 commits February 21, 2021 00:04
We have changed our implementation of package building
in CI, and some of the original implementation files
are no longer relevant.
The original readme.md file is no longer corresponding
to the current implementation of CI we have, so this is
bringing it more in line with the current state.
@NlightNFotis NlightNFotis requested a review from a team as a code owner February 22, 2021 09:58
@NlightNFotis NlightNFotis self-assigned this Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #5851 (4daa686) into develop (4d7158f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5851      +/-   ##
===========================================
+ Coverage    72.87%   72.89%   +0.01%     
===========================================
  Files         1421     1423       +2     
  Lines       154208   154229      +21     
===========================================
+ Hits        112386   112426      +40     
+ Misses       41822    41803      -19     
Impacted Files Coverage Δ
src/analyses/goto_check.cpp 88.28% <100.00%> (+0.02%) ⬆️
src/goto-diff/goto_diff_parse_options.cpp 58.67% <0.00%> (-4.13%) ⬇️
src/cbmc/cbmc_parse_options.cpp 75.20% <0.00%> (-1.07%) ⬇️
src/goto-analyzer/goto_analyzer_parse_options.cpp 73.25% <0.00%> (-0.61%) ⬇️
src/goto-instrument/dump_c.cpp 79.97% <0.00%> (-0.08%) ⬇️
.../goto-instrument/goto_instrument_parse_options.cpp 58.20% <0.00%> (-0.08%) ⬇️
src/util/std_code.h 94.00% <0.00%> (-0.06%) ⬇️
...rc/goto-instrument/goto_instrument_parse_options.h 100.00% <0.00%> (ø)
src/goto-programs/process_goto_program.cpp 100.00% <0.00%> (ø)
unit/util/format.cpp 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46de6f6...4daa686. Read the comment docs.

* `pull-request-check-clang-format.sh` -> Script that's called per Pull Request
to execute `clang-format` over changes.
* `pull-request-checks.yaml` -> Configuration file for the Github Actions CI jobs
for the various platforms.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Might be nice to have a list of which platforms/build systems we are currently testing on pull requests.

Add some information to the readme with regard to the main
platforms we are building/testing CBMC on Github Actions.
@NlightNFotis NlightNFotis merged commit c9679ab into diffblue:develop Feb 23, 2021
@NlightNFotis NlightNFotis deleted the cleanup_github_folder branch February 23, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants