Pointer arithmetic check: do not use pointer-to-int conversion #5849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently have a sound pointer-to-int conversion, and thus arithmetic involving pointers and integers does not translate to arithmetic over the integer representation of a pointer. With the recently added bounds checks on pointers involved in arithmetic we have a more reliable way of testing for overflow in pointer arithmetic.
tautschnig
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel and
smowton
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5849 +/- ##
========================================
Coverage 72.87% 72.87%
========================================
Files 1421 1421
Lines 154181 154208 +27
========================================
+ Hits 112359 112386 +27
Misses 41822 41822
Continue to review full report at Codecov.
|
martin-cs
approved these changes
Feb 20, 2021
martin-cs
approved these changes
Feb 21, 2021
| @@ -1177,22 +1177,6 @@ void goto_checkt::pointer_overflow_check( | |||
| expr.operands().size() == 2, | |||
| "pointer arithmetic expected to have exactly 2 operands"); | |||
|
|
|||
| // check for address space overflow by checking for overflow on integers | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently have a sound pointer-to-int conversion, and thus
arithmetic involving pointers and integers does not translate to
arithmetic over the integer representation of a pointer.
With the recently added bounds checks on pointers involved in arithmetic
we have a more reliable way of testing for overflow in pointer
arithmetic.