Skip to content

generate_ansi_c_start_function reports user errors via return code #5834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Do not throw an exception upon invalid source input. Instead, print an
error message and return true.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #5834 (2c59e0d) into develop (21a6267) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5834   +/-   ##
========================================
  Coverage    76.10%   76.10%           
========================================
  Files         1548     1548           
  Lines       166326   166334    +8     
========================================
+ Hits        126576   126584    +8     
  Misses       39750    39750           
Impacted Files Coverage Δ
src/ansi-c/ansi_c_entry_point.cpp 87.89% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c403a...2c59e0d. Read the comment docs.

@tautschnig tautschnig force-pushed the fix-generate_ansi_c_start_function branch from 57b4fb9 to 8bc7069 Compare February 18, 2021 02:52
@tautschnig tautschnig force-pushed the fix-generate_ansi_c_start_function branch from 8bc7069 to 7899b78 Compare March 16, 2021 23:52
@tautschnig tautschnig force-pushed the fix-generate_ansi_c_start_function branch from 7899b78 to 19362c6 Compare May 7, 2021 06:20
@tautschnig tautschnig force-pushed the fix-generate_ansi_c_start_function branch from 19362c6 to 45582e0 Compare August 13, 2021 11:19
Do not throw an exception upon invalid source input. Instead, print an
error message and return `true`.
@tautschnig tautschnig force-pushed the fix-generate_ansi_c_start_function branch from 45582e0 to 2c59e0d Compare December 5, 2021 23:58
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks more appropriate to the test of this function body.

@tautschnig tautschnig merged commit a0fe71a into diffblue:develop Jan 22, 2022
@tautschnig tautschnig deleted the fix-generate_ansi_c_start_function branch January 22, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants