Skip to content

Byte extract with negative offset must not fail invariant #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

tautschnig
Copy link
Collaborator

The code has provisions for handling negative offsets in a byte extract,
but then tried to convert only parts of index to an unsigned number: the
overall index is known to be non-negative in this branch, but the offset
alone may still be negative.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The code has provisions for handling negative offsets in a byte extract,
but then tried to convert only parts of index to an unsigned number: the
overall index is known to be non-negative in this branch, but the offset
alone may still be negative.
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #5820 (0255dd3) into develop (3cb60fc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5820   +/-   ##
========================================
  Coverage    69.83%   69.83%           
========================================
  Files         1242     1242           
  Lines       100842   100842           
========================================
  Hits         70422    70422           
  Misses       30420    30420           
Flag Coverage Δ
cproversmt2 43.61% <0.00%> (ø)
regression 66.79% <100.00%> (ø)
unit 32.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/flattening/boolbv_byte_extract.cpp 72.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb60fc...0255dd3. Read the comment docs.

@kroening kroening merged commit 23c11e8 into diffblue:develop Feb 12, 2021
@tautschnig tautschnig deleted the negative-byte-extract branch February 12, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants