Skip to content

[CI] [Hotfix] Add an apt-update step to the ubuntu CI jobs. #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

[CI] [Hotfix] Add an apt-update step to the ubuntu CI jobs. #5816

merged 1 commit into from
Feb 11, 2021

Conversation

NlightNFotis
Copy link
Contributor

This stops it from getting an HTTP 404 while downloading
dependencies if they have been updated since the image
came out.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Feb 11, 2021
@NlightNFotis NlightNFotis requested a review from a team as a code owner February 11, 2021 14:57
@NlightNFotis
Add an apt-get update step to the ubuntu CI builds.
9171ef3 
This stops it from getting an HTTP 404 while downloading
dependencies if they have been updated since the image
came out. This has been an issue for example with the
check-docker-image build, which was failing because of
a dependency moved.
@NlightNFotis NlightNFotis force-pushed the fix-docker-image-check-dependencies-fetching branch from 378a523 to 9171ef3 Compare February 11, 2021 15:03
@NlightNFotis NlightNFotis changed the title [CI] [Hotfix] Add an apt-update step to the docker pull request check. [CI] [Hotfix] Add an apt-update step to the ubuntu CI jobs. Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021 •
edited
Loading

Codecov Report

Merging #5816 (9171ef3) into develop (3b406c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5816   +/-   ##
========================================
  Coverage    69.83%   69.83%           
========================================
  Files         1242     1242           
  Lines       100841   100841           
========================================
  Hits         70420    70420           
  Misses       30421    30421
Flag Coverage Δ
cproversmt2 43.61% <ø> (ø)
regression 66.79% <ø> (ø)
unit 32.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b406c6...9171ef3. Read the comment docs.

piotr-grabalski
piotr-grabalski approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@piotr-grabalski piotr-grabalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks quite straightforward

@NlightNFotis NlightNFotis merged commit 3cb60fc into diffblue:develop Feb 11, 2021
@NlightNFotis NlightNFotis deleted the fix-docker-image-check-dependencies-fetching branch February 11, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue left review comments

@piotr-grabalski piotr-grabalski piotr-grabalski approved these changes

Assignees

@NlightNFotis NlightNFotis

Labels
bugfix CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NlightNFotis @hannes-steffenhagen-diffblue @piotr-grabalski