Skip to content

remove dead boolbvt::literals(...) #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Conversation

kroening
Copy link
Member

This method has no users, and can be removed.

Deprecation appears unnecessary given that external users of the API have
much better alternatives to achieve the same.

  • X ] Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This method has no users, and can be removed.

Deprecation appears unnecessary given that external users of the API have
much better alternatives to achieve the same.
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #5810 (37762a1) into develop (5fd8562) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5810      +/-   ##
===========================================
+ Coverage    69.72%   69.75%   +0.02%     
===========================================
  Files         1242     1242              
  Lines       100907   100873      -34     
===========================================
+ Hits         70361    70362       +1     
+ Misses       30546    30511      -35     
Flag Coverage Δ
cproversmt2 43.40% <ø> (+0.02%) ⬆️
regression 66.71% <ø> (+0.02%) ⬆️
unit 32.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/flattening/boolbv.cpp 76.49% <ø> (+6.91%) ⬆️
src/solvers/flattening/boolbv.h 78.57% <ø> (ø)
src/solvers/prop/prop_conv_solver.cpp 87.82% <ø> (+1.92%) ⬆️
src/solvers/prop/prop_conv_solver.h 37.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd8562...37762a1. Read the comment docs.

@kroening kroening marked this pull request as ready for review February 10, 2021 13:58
@kroening kroening merged commit b902e0b into develop Feb 10, 2021
@kroening kroening deleted the remove-boolbvt-literals branch February 10, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants