Remove {f,F}orall_literals

[tautschnig]

This was useful in the past, but with C++-11 we can use a ranged-for to avoid
the iterator altogether.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #5787 (692553f) into develop (26b655b) will increase coverage by 0.00%.
The diff coverage is 59.45%.

@@           Coverage Diff            @@
##           develop    #5787   +/-   ##
========================================
  Coverage    69.64%   69.64%           
========================================
  Files         1248     1248           
  Lines       100915   100911    -4     
========================================
- Hits         70285    70284    -1     
+ Misses       30630    30627    -3     

Flag	Coverage Δ
cproversmt2	43.36% <43.24%> (+<0.01%)	⬆️
regression	66.62% <59.45%> (+<0.01%)	⬆️
unit	32.18% <43.24%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/solvers/flattening/boolbv_case.cpp	0.00% <0.00%> (ø)
src/solvers/flattening/boolbv_complex.cpp	0.00% <0.00%> (ø)
src/solvers/flattening/boolbv_cond.cpp	0.00% <0.00%> (ø)
src/solvers/flattening/boolbv_vector.cpp	0.00% <0.00%> (ø)
src/solvers/prop/literal.h	68.75% <ø> (ø)
src/solvers/prop/prop_minimize.cpp	0.00% <0.00%> (ø)
src/solvers/refinement/refine_arrays.cpp	37.20% <0.00%> (ø)
src/solvers/sat/external_sat.cpp	49.20% <0.00%> (ø)
src/solvers/flattening/boolbv_typecast.cpp	44.03% <66.66%> (+0.18%)	⬆️
src/solvers/flattening/boolbv.cpp	69.39% <100.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b655b...692553f. Read the comment docs.

[kroening]

litera vs. literal?

[tautschnig]

Fixed, thanks!

[hannes-steffenhagen-diffblue]

LGTM