Skip to content

[HOTFIX] Rename version tag during release. #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

[HOTFIX] Rename version tag during release. #5776

merged 1 commit into from
Jan 21, 2021

Conversation

NlightNFotis
Copy link
Contributor

Because of a recent refactoring during to our
regular release process script, we misnamed
the release tag, causing a number of automated
systems that were dependent on a specific form
of a release tag (e.g cbmc-<version>) to fall
over.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis requested a review from a team as a code owner January 21, 2021 14:43
@NlightNFotis NlightNFotis self-assigned this Jan 21, 2021
hannes-steffenhagen-diffblue
hannes-steffenhagen-diffblue suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, related: When we do a sort-of experimental realease this should be cbmc-$VERSION[.extra-stuff] so the .extra-stuff is included in the version. If you push cbmc-x.x.x that should be an actual release that people are meant to use, if you push up something that's not meant to be used by end users that should be obvious from the version name.

.github/workflows/regular-release.yaml Outdated
@@ -35,8 +35,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.DB_CI_CPROVER_ACCESS_TOKEN }}
CBMC_TAG: ${{ needs.get-version-information.outputs.version }}
with:
tag_name: ${{ env.CBMC_TAG }}
release_name: ${{ env.CBMC_TAG }}
tag_name: cbmc-${{ env.CBMC_TAG }}
Copy link
Contributor

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Jan 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why not just have two outputs, one with the version number and one with the full tag name?

@NlightNFotis
[HOTFIX] Rename version tag during release.
81fb0b1 
Because of a recent refactoring during to our
regular release process script, we misnamed
the release tag, causing a number of automated
systems that were dependent on a specific form
of a release tag (e.g `cbmc-<version>`) to fall
over.
@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #5776 (81fb0b1) into develop (08c9ae9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5776   +/-   ##
========================================
  Coverage    69.68%   69.68%           
========================================
  Files         1248     1248           
  Lines       100855   100855           
========================================
  Hits         70278    70278           
  Misses       30577    30577
Flag Coverage Δ
cproversmt2 43.43% <ø> (ø)
regression 66.66% <ø> (ø)
unit 32.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c9ae9...81fb0b1. Read the comment docs.

@NlightNFotis NlightNFotis merged commit ec21533 into diffblue:develop Jan 21, 2021
@NlightNFotis NlightNFotis deleted the cbmc-5.22.1-hotfix branch January 21, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue approved these changes

Assignees

@NlightNFotis NlightNFotis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NlightNFotis @hannes-steffenhagen-diffblue