Skip to content

[CI] Get version information from $GITHUB_REF. #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

This deactivates the usage of the bruce_adams/get-release-info
action which was problematic for our usage, in favour of getting
release info from github environment variables.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis requested a review from a team as a code owner January 18, 2021 15:19
@NlightNFotis NlightNFotis self-assigned this Jan 18, 2021
@NlightNFotis NlightNFotis force-pushed the dockerhub_action_third_fix branch from cb1b320 to 030d57c Compare January 18, 2021 15:29
This deactivates the usage of the bruce_adams/get-release-info
action which was failing to get the release tag, in favour of getting
release info from github environment variables.
@NlightNFotis NlightNFotis force-pushed the dockerhub_action_third_fix branch from 030d57c to eae8d09 Compare January 18, 2021 15:33
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #5761 (eae8d09) into develop (6c59fc8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5761   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1245     1245           
  Lines       100842   100842           
========================================
  Hits         70242    70242           
  Misses       30600    30600           
Flag Coverage Δ
cproversmt2 43.39% <ø> (ø)
regression 66.56% <ø> (ø)
unit 32.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c59fc8...eae8d09. Read the comment docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me.

@NlightNFotis NlightNFotis merged commit 5df251d into diffblue:develop Jan 19, 2021
@NlightNFotis NlightNFotis deleted the dockerhub_action_third_fix branch January 19, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants