Skip to content

Switch the OSX universal binary build to X86 + ARM64 #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

kroening
Copy link
Member

This adds support for ARM64 and removes the support for i386. Support for
i386 has been removed from XCode, and the building with this target fails
owing to missing libraries for this architecture.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds support for ARM64 and removes the support for i386.  Support for
i386 has been removed from XCode, and building with this target fails
owing to missing libraries for this architecture.
@kroening kroening force-pushed the OSX-Universal-arm64 branch from 47e270b to ec939e1 Compare January 11, 2021 09:35
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #5736 (ec939e1) into develop (ba467ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5736   +/-   ##
========================================
  Coverage    69.49%   69.49%           
========================================
  Files         1243     1243           
  Lines       100701   100701           
========================================
  Hits         69985    69985           
  Misses       30716    30716           
Flag Coverage Δ
cproversmt2 43.26% <ø> (ø)
regression 66.39% <ø> (ø)
unit 32.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba467ef...ec939e1. Read the comment docs.

@kroening kroening merged commit 4cc9611 into develop Jan 11, 2021
@kroening kroening deleted the OSX-Universal-arm64 branch January 11, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants