Skip to content

C front-end: fallthrough and __fallthrough__ are the same attribute #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

tautschnig
Copy link
Collaborator

We already supported the former, but were missing the latter form.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #5730 (f215721) into develop (111b51e) will decrease coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5730      +/-   ##
===========================================
- Coverage    73.55%   72.90%   -0.65%     
===========================================
  Files         1431     1425       -6     
  Lines       155248   154279     -969     
===========================================
- Hits        114189   112482    -1707     
- Misses       41059    41797     +738     
Impacted Files Coverage Δ
src/ansi-c/parser.y 77.83% <100.00%> (+<0.01%) ⬆️
src/ansi-c/scanner.l 61.71% <100.00%> (+0.10%) ⬆️
src/goto-instrument/accelerate/accelerate.h 0.00% <0.00%> (-100.00%) ⬇️
src/goto-instrument/accelerate/path_enumerator.h 0.00% <0.00%> (-100.00%) ⬇️
...c/goto-instrument/accelerate/sat_path_enumerator.h 0.00% <0.00%> (-100.00%) ⬇️
...goto-instrument/accelerate/overflow_instrumenter.h 0.00% <0.00%> (-100.00%) ⬇️
...oto-instrument/accelerate/polynomial_accelerator.h 0.00% <0.00%> (-100.00%) ⬇️
...trument/accelerate/enumerating_loop_acceleration.h 0.00% <0.00%> (-100.00%) ⬇️
src/goto-instrument/accelerate/scratch_program.h 0.00% <0.00%> (-92.86%) ⬇️
...rc/goto-instrument/accelerate/acceleration_utils.h 0.00% <0.00%> (-75.00%) ⬇️
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a28135...7175961. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine although I guess us ignoring it means that we are saying this is too syntactic for us. As there is a -W flag for it, I thing that is reasonable.

@tautschnig tautschnig force-pushed the attribute-fallthrough branch from 5c642fc to f215721 Compare March 3, 2021 07:52
We already supported the former, but were missing the latter form.
@tautschnig tautschnig force-pushed the attribute-fallthrough branch from f215721 to 7175961 Compare March 15, 2021 13:42
@kroening kroening merged commit 276b8d7 into diffblue:develop Mar 15, 2021
@tautschnig tautschnig deleted the attribute-fallthrough branch March 15, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants