Skip to content

GCC switch range: don't enumerate elements #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

tautschnig
Copy link
Collaborator

Enumerating large ranges takes a long time or results in exhausting
resources. Generate less-or-equal pairs instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Enumerating large ranges takes a long time or results in exhausting
resources. Generate less-or-equal pairs instead.
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #5724 (192ebd7) into develop (932599e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5724      +/-   ##
===========================================
- Coverage    69.51%   69.51%   -0.01%     
===========================================
  Files         1243     1243              
  Lines       100695   100697       +2     
===========================================
+ Hits         69994    69995       +1     
- Misses       30701    30702       +1     
Flag Coverage Δ
cproversmt2 43.28% <100.00%> (+<0.01%) ⬆️
regression 66.40% <100.00%> (-0.01%) ⬇️
unit 32.25% <45.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/goto-programs/goto_convert.cpp 90.03% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932599e...192ebd7. Read the comment docs.

@tautschnig tautschnig self-assigned this Jan 8, 2021
@tautschnig tautschnig merged commit b72af07 into diffblue:develop Jan 8, 2021
@tautschnig tautschnig deleted the switch-range branch January 8, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants