Make Glucose configuration build after solver hardness changes #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
martin-cs,
peterschrammel and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5709 +/- ##
========================================
Coverage 69.50% 69.50%
========================================
Files 1243 1243
Lines 100690 100690
========================================
Hits 69989 69989
Misses 30701 30701
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tautschnig
force-pushed
the
fix-glucose
branch
2 times, most recently
from
0887cfe to
c8d3d13
Compare
In diffblue#5480 the solver hardness interface was updated, but changes were only implemented in the Minisat2 interface. Update the Glucose interface to match these changes. To avoid future regressions, make the check-macos-10_15-cmake-clang GitHub action use Glucose.
tautschnig
force-pushed
the
fix-glucose
branch
from
c8d3d13 to
948e75c
Compare
martin-cs
approved these changes
Jan 12, 2021
hannes-steffenhagen-diffblue
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5480 the solver hardness interface was updated, but changes were
only implemented in the Minisat2 interface. Update the Glucose interface
to match these changes.
To avoid future regressions, make the check-ubuntu-20_04-cmake-gcc
GitHub action use Glucose.