Skip to content

Xen-build GitHub action: use ccache and Ubuntu 20.04 #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

tautschnig
Copy link
Collaborator

The CBMC build in this action takes more than 10 minutes (building just
some selected directories), when the full build using ccache takes less
than 1 minute. Use ccache to achieve the same speed-up. As we only have
a make-build cache for 20.04, upgrade the environment to this Ubuntu
version.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from a team as a code owner December 27, 2020 08:52
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #5699 (a16b8e7) into develop (8ea67e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5699   +/-   ##
========================================
  Coverage    69.50%   69.50%           
========================================
  Files         1243     1243           
  Lines       100674   100674           
========================================
  Hits         69977    69977           
  Misses       30697    30697           
Flag Coverage Δ
cproversmt2 43.14% <ø> (ø)
regression 66.40% <ø> (ø)
unit 32.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea67e7...a16b8e7. Read the comment docs.

The CBMC build in this action takes more than 10 minutes (building just
some selected directories), when the full build using ccache takes less
than 1 minute. Use ccache to achieve the same speed-up. As we only have
a make-build cache for 20.04, upgrade the environment to this Ubuntu
version.
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NlightNFotis NlightNFotis merged commit caf309e into diffblue:develop Jan 12, 2021
@tautschnig tautschnig deleted the xen-ccache branch January 12, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants