Skip to content

OpenBSD can do binary merges with objcopy. #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

nanolith
Copy link
Contributor

Added defined(OpenBSD) to the platform check for binary merge in goto-cc/hybrid_binary.cpp

  • [ X ] Each commit message has a non-empty body, explaining why the change was made.
  • [ X ] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [ X ] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [ X ] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [ X ] My commit message includes data points confirming performance improvements (if claimed).
  • [ X ] My PR is restricted to a single feature or bugfix.
  • [ X ] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #5697 (9926a8f) into develop (e8c09d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5697   +/-   ##
========================================
  Coverage    69.50%   69.50%           
========================================
  Files         1243     1243           
  Lines       100674   100674           
========================================
  Hits         69977    69977           
  Misses       30697    30697           
Flag Coverage Δ
cproversmt2 43.14% <ø> (ø)
regression 66.40% <ø> (ø)
unit 32.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/goto-cc/hybrid_binary.cpp 69.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c09d3...9926a8f. Read the comment docs.

@tautschnig tautschnig merged commit c43385b into diffblue:develop Dec 26, 2020
@nanolith nanolith deleted the fix-openbsd-merge-binary branch December 27, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants