Skip to content

C library/time: fix wrong is-null test #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

tautschnig
Copy link
Collaborator

The assignment should happen if the pointer is non-null, not when it is
null. Also test this library function.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The assignment should happen if the pointer is non-null, not when it is
null. Also test this library function.
@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #5655 (c6f1ed5) into develop (4bd3c2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5655   +/-   ##
========================================
  Coverage    69.41%   69.41%           
========================================
  Files         1243     1243           
  Lines       100612   100612           
========================================
  Hits         69842    69842           
  Misses       30770    30770           
Flag Coverage Δ
cproversmt2 43.15% <ø> (ø)
regression 66.31% <ø> (ø)
unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd3c2f...c6f1ed5. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is an old bug. Makes me wonder if it has ever ben used!

@kroening kroening merged commit 813a0ad into diffblue:develop Dec 14, 2020
@tautschnig tautschnig deleted the library-time branch December 14, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants