Skip to content

strtol must not overflow #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2020
Merged

strtol must not overflow #5632

merged 1 commit into from
Nov 26, 2020

Conversation

tautschnig
Copy link
Collaborator

The lack of overflow checking in the internal library first showed up in
SV-COMP when running sv-benchmarks/c/busybox-1.22.0/ls-incomplete-2.i
with --unwind 21.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The lack of overflow checking in the internal library first showed up in
SV-COMP when running sv-benchmarks/c/busybox-1.22.0/ls-incomplete-2.i
with --unwind 21.
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5632 (31147d7) into develop (2858b18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5632   +/-   ##
========================================
  Coverage    69.36%   69.36%           
========================================
  Files         1241     1241           
  Lines       100564   100564           
========================================
  Hits         69753    69753           
  Misses       30811    30811           
Flag Coverage Δ
cproversmt2 43.15% <ø> (ø)
regression 66.26% <ø> (ø)
unit 32.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2858b18...31147d7. Read the comment docs.

@kroening kroening merged commit 01a2b26 into diffblue:develop Nov 26, 2020
@tautschnig tautschnig deleted the strtol branch November 26, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants