Skip to content

Mark unnecessarily-public members of compilet protected #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

tautschnig
Copy link
Collaborator

compilet has several public members, which should eventually have
setters/getters instead. To make clearer which those are, first mark
those that aren't needed outside the class protected.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

compilet has several public members, which should eventually have
setters/getters instead. To make clearer which those are, first mark
those that aren't needed outside the class protected.
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #5617 (be12593) into develop (4144414) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5617   +/-   ##
========================================
  Coverage    69.32%   69.32%           
========================================
  Files         1241     1241           
  Lines       100432   100432           
========================================
  Hits         69625    69625           
  Misses       30807    30807           
Flag Coverage Δ
cproversmt2 43.08% <ø> (ø)
regression 66.22% <ø> (ø)
unit 32.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/goto-cc/compile.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4144414...be12593. Read the comment docs.

Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable.

@kroening kroening merged commit b1521c9 into diffblue:develop Dec 18, 2020
@tautschnig tautschnig deleted the compilet-visibility branch December 18, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants