interpretert isn't a messaget #5595
Conversation
Use a messaget member instead as there is no is-a relationship between interpretert and messaget.
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5595 +/- ##
========================================
Coverage 69.32% 69.32%
========================================
Files 1242 1242
Lines 100418 100417 -1
========================================
Hits 69619 69619
+ Misses 30799 30798 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| { | ||
| public: | ||
| interpretert( | ||
| const symbol_tablet &_symbol_table, | ||
| const goto_functionst &_goto_functions, | ||
| message_handlert &_message_handler) | ||
| : messaget(_message_handler), | ||
| : output(_message_handler), |
There was a problem hiding this comment.
Why is this called output rather than log here?
There was a problem hiding this comment.
The interpreter necessarily provides user-facing output, i.e., is not useful if not printing some of the messages. So I thought "output" may be a better choice than "log" on this occasion. But I might well be wrong?
|
GH Actions failed due to network error, restarting (all of them because apparently there's no way to restart only a single one). |
Use a messaget member instead as there is no is-a relationship between
interpretert and messaget.