Skip to content

Fix PATH separator and CMake syntax to make cbmc-cprover-smt2 tests work on Windows #5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Nov 12, 2020

Windows separates PATH components by semicolons. add_test_pl_profile does not take more than 4 arguments.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5573 (313b682) into develop (9e97874) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5573   +/-   ##
========================================
  Coverage    69.37%   69.37%           
========================================
  Files         1241     1241           
  Lines       100519   100519           
========================================
  Hits         69731    69731           
  Misses       30788    30788           
Flag Coverage Δ
cproversmt2 43.15% <ø> (ø)
regression 66.27% <ø> (ø)
unit 32.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e97874...313b682. Read the comment docs.

@tautschnig tautschnig force-pushed the debug-winbug branch 11 times, most recently from e8a60ad to fa31846 Compare November 15, 2020 23:08
@tautschnig tautschnig changed the title Debug regression tests marked winbug [draft, do not review] Fix PATH separator and CMake syntax to make cbmc-cprover-smt2 tests work on Windows Nov 15, 2020
@tautschnig tautschnig marked this pull request as ready for review November 15, 2020 23:09
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would also like @hannes-steffenhagen-diffblue to take a look since he's more familiar with cmake than I am.

…ork on Windows

Windows separates PATH components by semicolons. add_test_pl_profile
does not take more than 4 arguments.
@tautschnig tautschnig merged commit 4d14272 into diffblue:develop Nov 20, 2020
@tautschnig tautschnig deleted the debug-winbug branch November 20, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants