-
Notifications
You must be signed in to change notification settings - Fork 274
[CI] Add a linux+clang+make github actions job. #5559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add a linux+clang+make github actions job. #5559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
DEBIAN_FRONTEND: noninteractive | ||
TESTPL_JOBS: 4 | ||
run: | | ||
sudo apt-get install -yq gcc gdb g++ maven jq flex bison libxml2-utils cpanminus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Do we need gcc gdb g++
for a clang
build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it - I opted for keeping the job's environment in line with the linux+make+gcc
one.
Though these are arguably not very useful given that they are preinstalled in Github runners. But I suggest this stays for now and we have a separate discussion on whether we should remove them from the other build as well.
4b50877
to
e1354e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Codecov Report
@@ Coverage Diff @@
## develop #5559 +/- ##
===========================================
- Coverage 72.85% 72.84% -0.01%
===========================================
Files 1421 1421
Lines 154130 154138 +8
===========================================
- Hits 112292 112289 -3
- Misses 41838 41849 +11
Continue to review full report at Codecov.
|
Please also make sure we port all the features of the CodeBuild jobs. Specifically, the "cbmc" CodeBuild job is running with
|
e1354e9
to
d60cf5d
Compare
d60cf5d
to
7f3a255
Compare
7878971
to
262da12
Compare
This replaces a codebuild job that had not been ported yet, so that codebuild can be safely deactivated as a CI provider, having all the configurations ported so far.
84f7791
to
81ecf05
Compare
This replaces a codebuild job that had not been ported yet,
so that codebuild can be safely deactivated as a CI provider,
having all the configurations ported so far.