Skip to content

[CI] Add a linux+clang+make github actions job. #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

NlightNFotis
Copy link
Contributor

This replaces a codebuild job that had not been ported yet,
so that codebuild can be safely deactivated as a CI provider,
having all the configurations ported so far.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DEBIAN_FRONTEND: noninteractive
TESTPL_JOBS: 4
run: |
sudo apt-get install -yq gcc gdb g++ maven jq flex bison libxml2-utils cpanminus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Do we need gcc gdb g++ for a clang build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it - I opted for keeping the job's environment in line with the linux+make+gcc one.

Though these are arguably not very useful given that they are preinstalled in Github runners. But I suggest this stays for now and we have a separate discussion on whether we should remove them from the other build as well.

@NlightNFotis NlightNFotis force-pushed the port_codebuild_make_job branch from 4b50877 to e1354e9 Compare November 11, 2020 14:27
Copy link
Contributor

@piotr-grabalski piotr-grabalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5559 (81ecf05) into develop (e5e8239) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5559      +/-   ##
===========================================
- Coverage    72.85%   72.84%   -0.01%     
===========================================
  Files         1421     1421              
  Lines       154130   154138       +8     
===========================================
- Hits        112292   112289       -3     
- Misses       41838    41849      +11     
Impacted Files Coverage Δ
src/solvers/flattening/bv_pointers.cpp 80.89% <0.00%> (-2.05%) ⬇️
src/solvers/flattening/bv_pointers.h 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268f886...81ecf05. Read the comment docs.

@tautschnig
Copy link
Collaborator

tautschnig commented Nov 11, 2020

Please also make sure we port all the features of the CodeBuild jobs. Specifically, the "cbmc" CodeBuild job is running with _GLIBCXX_DEBUG, which we don't seem to be doing in any of the GitHub actions just yet.

Also, I am wondering about the use of ccache to speed up builds? (done)

@NlightNFotis NlightNFotis force-pushed the port_codebuild_make_job branch from e1354e9 to d60cf5d Compare February 10, 2021 15:09
@NlightNFotis NlightNFotis changed the title Add a linux+clang+make github actions job. [CI] Add a linux+clang+make github actions job. Feb 10, 2021
@NlightNFotis NlightNFotis force-pushed the port_codebuild_make_job branch from d60cf5d to 7f3a255 Compare February 15, 2021 14:57
@NlightNFotis NlightNFotis force-pushed the port_codebuild_make_job branch from 7878971 to 262da12 Compare February 17, 2021 12:07
NlightNFotis and others added 2 commits February 17, 2021 15:38
This replaces a codebuild job that had not been ported yet,
so that codebuild can be safely deactivated as a CI provider,
having all the configurations ported so far.
@NlightNFotis NlightNFotis force-pushed the port_codebuild_make_job branch from 84f7791 to 81ecf05 Compare February 17, 2021 15:38
@NlightNFotis NlightNFotis merged commit eeb48a2 into diffblue:develop Feb 17, 2021
@NlightNFotis NlightNFotis deleted the port_codebuild_make_job branch February 17, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants