Skip to content

Make Glucose support compile #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Nov 6, 2020

Hardness support was added to minisat2 only. Also update the source
patch to ensure Glucose compiles without warnings when using recent
versions of GCC.

I'll keep this in Draft status as we should likely merge #5305 first and then reconsider whether we (still) want all of the changes in this PR. #5305 has been merged, but it still seems worthwhile fully fixing Glucose support.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #5548 (1c75269) into develop (d14e078) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5548   +/-   ##
========================================
  Coverage    68.53%   68.53%           
========================================
  Files         1187     1187           
  Lines        98263    98263           
========================================
  Hits         67347    67347           
  Misses       30916    30916           
Flag Coverage Δ
cproversmt2 43.09% <ø> (ø)
regression 65.71% <ø> (ø)
unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14e078...1c75269. Read the comment docs.

Hardness support was added to minisat2 only. Also update the source
patch to ensure Glucose compiles without warnings when using recent
versions of GCC.
@tautschnig tautschnig merged commit 27f2a8a into diffblue:develop Nov 10, 2020
@tautschnig tautschnig deleted the fix-glucose branch November 10, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants