Skip to content

Deactivate broken tests that depend on assert on MacOS. #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions regression/ansi-c/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,15 +1,32 @@
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
add_test_pl_tests(
"$<TARGET_FILE:goto-cc>" -X gcc-only
)
add_test_pl_tests(
"$<TARGET_FILE:goto-cc>" -X gcc-only
)
elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
add_test_pl_tests(
"$<TARGET_FILE:goto-cc>"
)

# In MacOS, a change in the assert.h header file
# is causing template errors when exercising the
# C++ front end (because of a transitive include
# of <type_traits>) for files that include the
# <assert.h> or <cassert> headers.
add_test_pl_profile(
"ansi-c-c++-front-end"
"$<TARGET_FILE:goto-cc> -xc++ -D_Bool=bool"
"-C;-I;test-c++-front-end;-s;c++-front-end-X;macos-assert-broken"
"CORE"
)
else()
add_test_pl_tests(
"$<TARGET_FILE:goto-cc>"
)
add_test_pl_profile(
"ansi-c-c++-front-end"
"$<TARGET_FILE:goto-cc> -xc++ -D_Bool=bool"
"-C;-I;test-c++-front-end;-s;c++-front-end"
"CORE"
)
add_test_pl_tests(
"$<TARGET_FILE:goto-cc>"
)

add_test_pl_profile(
"ansi-c-c++-front-end"
"$<TARGET_FILE:goto-cc> -xc++ -D_Bool=bool"
"-C;-I;test-c++-front-end;-s;c++-front-end"
"CORE"
)
endif()
26 changes: 20 additions & 6 deletions regression/ansi-c/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,35 @@ include ../../src/config.inc
include ../../src/common

ifeq ($(BUILD_ENV_),MSVC)
exe=../../../src/goto-cc/goto-cl -X gcc-only
exe = ../../../src/goto-cc/goto-cl
else
exe=../../../src/goto-cc/goto-cc
exe = ../../../src/goto-cc/goto-cc
endif

ifeq ($(BUILD_ENV_),MSVC)
excluded_tests = -X gcc-only
else
# In MacOS, a change in the assert.h header file
# is causing template errors when exercising the
# C++ front end (because of a transitive include
# of <type_traits>) for files that include the
# <assert.h> or <cassert> headers.
OS := $(shell uname)
ifeq ($(OS),Darwin)
excluded_tests = -X macos-assert-broken
endif
endif

test:
@../test.pl -e -p -c $(exe)
@../test.pl -e -p -c $(exe) $(excluded_tests)
ifneq ($(BUILD_ENV_),MSVC)
@../test.pl -e -p -c "$(exe) -xc++ -D_Bool=bool" -I test-c++-front-end -s c++-front-end
@../test.pl -e -p -c "$(exe) -xc++ -D_Bool=bool" -I test-c++-front-end -s c++-front-end $(excluded_tests)
endif

tests.log: ../test.pl
@../test.pl -e -p -c $(exe)
@../test.pl -e -p -c $(exe) $(excluded_tests)
ifneq ($(BUILD_ENV_),MSVC)
@../test.pl -e -p -c "$(exe) -xc++ -D_Bool=bool" -I test-c++-front-end -s c++-front-end
@../test.pl -e -p -c "$(exe) -xc++ -D_Bool=bool" -I test-c++-front-end -s c++-front-end $(excluded_tests)
endif

show:
Expand Down
2 changes: 1 addition & 1 deletion regression/ansi-c/array_initialization2/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE test-c++-front-end
CORE test-c++-front-end macos-assert-broken
main.c

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/ansi-c/float_constant2/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE test-c++-front-end
CORE test-c++-front-end macos-assert-broken
main.c

^EXIT=0$
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE test-c++-front-end
CORE test-c++-front-end macos-assert-broken
main.c

^EXIT=0$
Expand Down
8 changes: 7 additions & 1 deletion regression/cbmc-cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ else()
set(exclude_win_broken_tests "")
endif()

if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(exclude_mac_broken_tests -X macos-assert-broken)
else()
set(exclude_mac_broken_tests "")
endif()

add_test_pl_tests(
"$<TARGET_FILE:cbmc> --validate-goto-model --validate-ssa-equation" ${gcc_only} ${exclude_win_broken_tests}
"$<TARGET_FILE:cbmc> --validate-goto-model --validate-ssa-equation" ${gcc_only} ${exclude_win_broken_tests} ${exclude_mac_broken_tests}
)
2 changes: 1 addition & 1 deletion regression/cbmc-cpp/FunctionParam1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
CORE macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
16 changes: 12 additions & 4 deletions regression/cbmc-cpp/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,24 @@ include ../../src/config.inc
include ../../src/common

ifeq ($(BUILD_ENV_),MSVC)
gcc_only = -X gcc-only
excluded_tests = -X gcc-only
else
gcc_only =
# In MacOS, a change in the assert.h header file
# is causing template errors when exercising the
# C++ front end (because of a transitive include
# of <type_traits>) for files that include the
# <assert.h> or <cassert> headers.
OS := $(shell uname)
ifeq ($(OS),Darwin)
excluded_tests = -X macos-assert-broken
endif
endif

test:
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation" $(gcc_only)
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation" $(excluded_tests)

tests.log: ../test.pl
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation" $(gcc_only)
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation" $(excluded_tests)

show:
@for dir in *; do \
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-cpp/MethodParam1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
CORE macos-assert-broken
main.cpp

instance is SATISFIABLE$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-cpp/cpp-new/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
--pointer-check
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-cpp/cpp1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
--unwind 1 --unwinding-assertions
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-cpp/lvalue1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-cpp/union2/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
CORE macos-assert-broken
main.cpp
--little-endian
^EXIT=0$
Expand Down
8 changes: 7 additions & 1 deletion regression/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ else()
set(exclude_win_broken_tests "")
endif()

if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(exclude_mac_broken_tests -X macos-assert-broken)
else()
set(exclude_mac_broken_tests "")
endif()

add_test_pl_tests(
"$<TARGET_FILE:goto-cc>" ${gcc_only} ${exclude_win_broken_tests}
"$<TARGET_FILE:goto-cc>" ${gcc_only} ${exclude_win_broken_tests} ${exclude_mac_broken_tests}
)
23 changes: 18 additions & 5 deletions regression/cpp/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,29 @@ include ../../src/config.inc
include ../../src/common

ifeq ($(BUILD_ENV_),MSVC)
exe=../../../src/goto-cc/goto-cl -X gcc-only
exe = ../../../src/goto-cc/goto-cl
else
exe=../../../src/goto-cc/goto-cc
exe = ../../../src/goto-cc/goto-cc
endif

test:
@../test.pl -e -p -c $(exe)
ifeq ($(BUILD_ENV_),MSVC)
excluded_tests = -X gcc-only
else
# In MacOS, a change in the assert.h header file
# is causing template errors when exercising the
# C++ front end (because of a transitive include
# of <type_traits>) for files that include the
# <assert.h> or <cassert> headers.
OS := $(shell uname)
ifeq ($(OS),Darwin)
excluded_tests = -X macos-assert-broken
endif
endif

test:
@../test.pl -e -p -c $(exe) $(excluded_tests)
tests.log: ../test.pl
@../test.pl -e -p -c $(exe)
@../test.pl -e -p -c $(exe) $(excluded_tests)

show:
@for dir in *; do \
Expand Down
2 changes: 1 addition & 1 deletion regression/cpp/Method_qualifier1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cpp/auto1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
-std=c++11
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cpp/enum5/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cpp/switch1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cpp/virtual1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
CORE macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Array2/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
-DNO_IO -DNO_STRING
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Array3/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
-DNO_IO -DNO_STRING
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Array4/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
-DNO_IO -DNO_STRING
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/BitvectorCpp1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/BitvectorCpp2/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/BitvectorSc3/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
8 changes: 7 additions & 1 deletion regression/systemc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ else()
set(exclude_win_broken_tests "")
endif()

if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(exclude_mac_broken_tests -X macos-assert-broken)
else()
set(exclude_mac_broken_tests "")
endif()

add_test_pl_tests(
"$<TARGET_FILE:cbmc> --validate-goto-model --validate-ssa-equation" ${exclude_win_broken_tests}
"$<TARGET_FILE:cbmc> --validate-goto-model --validate-ssa-equation" ${exclude_win_broken_tests} ${exclude_mac_broken_tests}
)
2 changes: 1 addition & 1 deletion regression/systemc/ForwardDecl1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
16 changes: 14 additions & 2 deletions regression/systemc/Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,22 @@
ifneq ($(BUILD_ENV_),MSVC)
# In MacOS, a change in the assert.h header file
# is causing template errors when exercising the
# C++ front end (because of a transitive include
# of <type_traits>) for files that include the
# <assert.h> or <cassert> headers.
OS := $(shell uname)
ifeq ($(OS),Darwin)
excluded_tests = -X macos-assert-broken
endif
endif

default: tests.log

test:
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation"
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation" $(excluded_tests)

tests.log: ../test.pl
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation"
@../test.pl -e -p -c "../../../src/cbmc/cbmc --validate-goto-model --validate-ssa-equation" $(excluded_tests)

show:
@for dir in *; do \
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Masc1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/MascInst1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Reference1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/This1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp

^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Tuple1/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
-DNO_IO -DNO_STRING
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/systemc/Tuple2/test.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE winbug
CORE winbug macos-assert-broken
main.cpp
-DNO_IO -DNO_STRING
^EXIT=0$
Expand Down