-
Notifications
You must be signed in to change notification settings - Fork 273
Remove deprecated windows package building scripts. #5535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated windows package building scripts. #5535
Conversation
The scripts removed are from an early attempt to build and package a CBMC distribution on windows, that has now been deprecated since we delegate to CMake (CPack) to build a windows installer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the .github/workflows/debian
and .github/workflows/macos15
directories go as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable but it would be good to have someone who is a windows user comment on this. Were these scripts used for anything else apart from CI?
@martin-cs We have talked (offline) to the original contributor of these scripts, and unless I'm badly mistaken he agreed to us removing them. Yes, also these scripts where only used on CI - we now have them substituted with the ones in |
@thomasspriggs Maybe, but as a part of another PR 👍 |
@NlightNFotis Great! Thanks. |
Codecov Report
@@ Coverage Diff @@
## develop #5535 +/- ##
========================================
Coverage 68.52% 68.52%
========================================
Files 1187 1187
Lines 98265 98265
========================================
Hits 67339 67339
Misses 30926 30926
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Also, ignore the codecov project, the report seems to be spurious - this PR doesn't add or remove coverage - it's only removing CI config files. |
The scripts removed are from an early attempt to build
and package a CBMC distribution on windows, that has
now been deprecated since we delegate to CMake (CPack)
to build a windows installer.