Skip to content

Remove deprecated windows package building scripts. #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

@NlightNFotis NlightNFotis commented Oct 20, 2020

The scripts removed are from an early attempt to build
and package a CBMC distribution on windows, that has
now been deprecated since we delegate to CMake (CPack)
to build a windows installer.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The scripts removed are from an early attempt to build
and package a CBMC distribution on windows, that has
now been deprecated since we delegate to CMake (CPack)
to build a windows installer.
@NlightNFotis NlightNFotis requested a review from a team as a code owner October 20, 2020 15:35
@NlightNFotis NlightNFotis self-assigned this Oct 20, 2020
Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the .github/workflows/debian and .github/workflows/macos15 directories go as well?

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable but it would be good to have someone who is a windows user comment on this. Were these scripts used for anything else apart from CI?

@NlightNFotis
Copy link
Contributor Author

@martin-cs We have talked (offline) to the original contributor of these scripts, and unless I'm badly mistaken he agreed to us removing them.

Yes, also these scripts where only used on CI - we now have them substituted with the ones in .github/workflows/release-packages.yaml.

@NlightNFotis
Copy link
Contributor Author

@thomasspriggs Maybe, but as a part of another PR 👍

@martin-cs
Copy link
Collaborator

@NlightNFotis Great! Thanks.

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #5535 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5535   +/-   ##
========================================
  Coverage    68.52%   68.52%           
========================================
  Files         1187     1187           
  Lines        98265    98265           
========================================
  Hits         67339    67339           
  Misses       30926    30926           
Flag Coverage Δ
#cproversmt2 42.96% <ø> (ø)
#regression 65.68% <ø> (ø)
#unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac232b...75ce37f. Read the comment docs.

@NlightNFotis
Copy link
Contributor Author

Also, ignore the codecov project, the report seems to be spurious - this PR doesn't add or remove coverage - it's only removing CI config files.

@NlightNFotis NlightNFotis merged commit a46f12d into diffblue:develop Oct 20, 2020
@NlightNFotis NlightNFotis deleted the drop_package_build_scripts branch October 20, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants