Skip to content

Remove travis configuration files. #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

NlightNFotis
Copy link
Contributor

@NlightNFotis NlightNFotis commented Oct 16, 2020

After porting the travis jobs to github actions, it doesn't make a lot of sense to keep travis around, especially since we have come up with a host of problems with it, including, but not limited to:

  • builds timing out on a regular basis
  • builds failing because of travis' networking problems
  • contributors not having rights to restart failing jobs corresponding to their PRs
  • misconfiguration of the build pipeline causing CI runs taking a whole load more than they need to.

After this is merged, the aim is to slowly phase out the codebuild jobs as well.

NOTE: This should be merged after the last travis check (building against debug libstdc++ has been merged).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

After porting the travis jobs to github
actions, it doesn't make a lot of sense
to keep travis around, especially since
we have come up with a host of problems
with it, including, but not limited to:

* builds timing out on a regular basis
* builds failing because of travis'
  networking problems
* contributors not having rights to restart
  failing jobs corresponding to their PRs
* misconfiguration of the build pipeline
  causing CI runs taking a whole load more
  than they need to.
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good as long as the external access to the logs of the other build systems continues to work.

Copy link
Contributor

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on removing trace files/mentions and also documenting why we’re doing this!

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #5533 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5533   +/-   ##
========================================
  Coverage    68.52%   68.52%           
========================================
  Files         1187     1187           
  Lines        98265    98265           
========================================
  Hits         67339    67339           
  Misses       30926    30926           
Flag Coverage Δ
#cproversmt2 42.96% <ø> (ø)
#regression 65.68% <ø> (ø)
#unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4e0c4...ae4a6a2. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 6ab28e1 into diffblue:develop Oct 16, 2020
@NlightNFotis NlightNFotis deleted the purge_travis branch October 16, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants