Skip to content

Make myself codeowner for CMake files #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hannes-steffenhagen-diffblue
Copy link
Contributor

Proposing myself to be added as codeowner for CMake related files, because based on observation I’m probably the person who cares the most about CMake around here.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; it is good to align owner, maintainer and "care about". To avoid bottlenecks and so that you have people to approve your PRs -- is there anyone else that could be listed?

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are our resident CMake expert :-) this makes total sense to me!

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #5466 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5466   +/-   ##
========================================
  Coverage    68.25%   68.25%           
========================================
  Files         1180     1180           
  Lines        97722    97722           
========================================
  Hits         66698    66698           
  Misses       31024    31024           
Flag Coverage Δ
#cproversmt2 42.81% <ø> (ø)
#regression 65.42% <ø> (ø)
#unit 32.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0f218...3d28e49. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 03e77f7 into diffblue:develop Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants