Skip to content

Fix AWS windows cmake CI #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

@thomasspriggs thomasspriggs commented Aug 17, 2020

Install bison and flex on the windows cmake build from cyg-get. Because the chocolatey package for flex and bison is currently broken, due to a dead link.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Because the chocolatey package for flex and bison is currently broken,
due to a dead link.
@thomasspriggs thomasspriggs force-pushed the tas/fix_windows_bison_dependency branch from 61fcb8e to c4ba38f Compare August 17, 2020 16:04
@@ -9,7 +9,9 @@ phases:
install:
commands:
- choco install -y --no-progress cmake --installargs 'ADD_CMAKE_TO_PATH=System'
- choco install -y --no-progress winflexbison3 ninja
- choco install cyg-get -y --no-progress

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about installing one package manager with another package manager so the managed package manager can manage some packages is hurting my brain.

@thomasspriggs thomasspriggs changed the title Fix windows CI Fix AWS windows cmake CI Aug 17, 2020
@thomasspriggs thomasspriggs marked this pull request as ready for review August 17, 2020 16:41
@thomasspriggs thomasspriggs merged commit 569014b into diffblue:develop Aug 18, 2020
@thomasspriggs thomasspriggs deleted the tas/fix_windows_bison_dependency branch August 18, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants