Port ancillary jobs from Travis to github actions #5457
Conversation
thomasspriggs
force-pushed
the
tas/gha_ancillaries
branch
2 times, most recently
from
21c01d6 to
107578a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5457 +/- ##
========================================
Coverage 68.23% 68.23%
========================================
Files 1178 1178
Lines 97588 97588
========================================
Hits 66589 66589
Misses 30999 30999
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #5457 +/- ##
========================================
Coverage 68.25% 68.25%
========================================
Files 1180 1180
Lines 97722 97722
========================================
Hits 66698 66698
Misses 31024 31024
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true |
There was a problem hiding this comment.
To get this to work you’d want fetch_depth: 0 here to check out the entire repository rather than create a shallow clone (the default).
thomasspriggs
force-pushed
the
tas/gha_ancillaries
branch
5 times, most recently
from
5c83767 to
67747cc
Compare
This was formerly a Travis CI job. Setting it up using Github actions gives us a user interface which integrates into the rest of github better. This is a step towards having all jobs seup in Github actions and removing Travis.
thomasspriggs
force-pushed
the
tas/gha_ancillaries
branch
from
a034075 to
094fb6e
Compare
thomasspriggs
force-pushed
the
tas/gha_ancillaries
branch
from
094fb6e to
872a676
Compare
This was formerly a Travis CI job. Setting it up using Github actions gives us a user interface which integrates into the rest of github better. This is a step towards having all jobs seup in Github actions and removing Travis.
This was formerly a Travis CI job. Setting it up using Github actions gives us a user interface which integrates into the rest of github better. This is a step towards having all jobs seup in Github actions and removing Travis.
thomasspriggs
force-pushed
the
tas/gha_ancillaries
branch
from
872a676 to
5379a73
Compare
thomasspriggs
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
| git diff > formatted.diff | ||
| if [[ -s formatted.diff ]] ; then | ||
| echo 'Formatting error! The following diff shows the required changes' | ||
| echo 'Use the raw log to get a version of the diff that preserves spacing' |
There was a problem hiding this comment.
Is this referring to how the github action log presents this?
There was a problem hiding this comment.
This was just cut and paste from the Travis version. I am not sure if viewing in github actions preserves spacing or not.
|
|
||
| # Find the commit on which the PR is based. | ||
| MERGE_BASE=$(git merge-base ${BASE_BRANCH} ${MERGE_BRANCH}) | ||
| echo "Checking standards of code touched since $MERGE_BASE" |
There was a problem hiding this comment.
Something which would be really cool is if we could use https://github.com/marketplace/actions/annotations-action to display inline comments with the needed changes (not an action for this PR, just food for thought for follow-up work).
| echo "Checking standards of code touched since $MERGE_BASE" | ||
|
|
||
| # Do the checking. | ||
| script_folder='./scripts' |
There was a problem hiding this comment.
I feel like this variable isn’t adding a ton of value here.
These were formerly a Travis CI jobs. Setting them up using Github actions gives us a user interface which integrates into the rest of github better. This is a step towards having all jobs setup in Github actions and removing Travis.