Skip to content

Ci/ubuntu 20.04 GitHub action #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2020
Merged

Ci/ubuntu 20.04 GitHub action #5444

merged 1 commit into from
Aug 19, 2020

Conversation

hannes-steffenhagen-diffblue
Copy link
Contributor

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue commented Aug 6, 2020 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Aug 6, 2020 •
edited
Loading

Codecov Report

Merging #5444 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5444   +/-   ##
========================================
  Coverage    68.25%   68.25%           
========================================
  Files         1180     1180           
  Lines        97722    97722           
========================================
  Hits         66698    66698           
  Misses       31024    31024
Flag Coverage Δ
#cproversmt2 42.81% <ø> (ø)
#regression 65.42% <ø> (ø)
#unit 32.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff4d49...e58dad8. Read the comment docs.

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue force-pushed the CI/ubuntu-20.20-github-action branch 2 times, most recently from ec532f5 to c49496b Compare August 7, 2020 10:55
@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue changed the title Ci/ubuntu 20.20 GitHub action Ci/ubuntu 20.04 GitHub action Aug 7, 2020
@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue marked this pull request as ready for review August 7, 2020 13:53
thomasspriggs
thomasspriggs reviewed Aug 11, 2020
View reviewed changes
.github/workflows/pull-request-checks.yaml
- name: Build with Ninja
run: cd build; ninja
- name: Run tests
run: cd build; ctest . -V -L CORE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run the unit tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

NlightNFotis
NlightNFotis approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomasspriggs
thomasspriggs approved these changes Aug 17, 2020
View reviewed changes
.github/workflows/pull-request-checks.yaml Outdated
# This is needed in addition to -yq to prevent apt-get from asking for
# user input
DEBIAN_FRONTEND: noninteractive
run: sudo apt-get install -yq cmake ninja-build gcc g++ maven flex bison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Maybe add libxml2-utils for xmllint testing.

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue merged commit 0d0f218 into diffblue:develop Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NlightNFotis NlightNFotis NlightNFotis approved these changes

@danpoe danpoe danpoe approved these changes

@chrisr-diffblue chrisr-diffblue chrisr-diffblue approved these changes

@thomasspriggs thomasspriggs thomasspriggs approved these changes

@kroening kroening Awaiting requested review from kroening

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@smowton smowton Awaiting requested review from smowton

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hannes-steffenhagen-diffblue @NlightNFotis @danpoe @chrisr-diffblue @thomasspriggs