GitHub actions #5433
Merged
GitHub actions #5433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2020 19:13
The GitHub Actions builds one set of installers that installs into the operating system's equivalent of /usr/local/bin, and a second set of installers that installs into the equivalent of /usr/local/cbmc-latest/bin. This patch removes the second set of installers and leaves only those installing into /usr/local/bin.
markrtuttle
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5433 +/- ##
========================================
Coverage 68.21% 68.21%
========================================
Files 1178 1178
Lines 97561 97561
========================================
Hits 66554 66554
Misses 31007 31007
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
kroening
approved these changes
Jul 27, 2020
.github/workflows/packages.yaml
Outdated
|
|
||
| Ubuntu18_Stable: | ||
| # Ubuntu16_Latest: | ||
| # name: Ubuntu 16 cbmc-latest package |
There was a problem hiding this comment.
Simply get rid of the commented lines?
.github/workflows/packages.yaml
Outdated
| @@ -242,19 +242,19 @@ jobs: | |||
| run: | | |||
| make -f ${SCRIPT_DIR}/Makefile | |||
| mv cbmc.tar.gz ${PACKAGE_STABLE_NAME} | |||
| mv cbmc-latest.tar.gz ${PACKAGE_LATEST_NAME} | |||
| # mv cbmc-latest.tar.gz ${PACKAGE_LATEST_NAME} | |||
There was a problem hiding this comment.
Also remove PACKAGE_LATEST_NAME environment variable above.
thomasspriggs
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
I second @kroening 's comments on removing the (now dead) build instructions, otherwise it's good to go.
Please implement this and I will approve and merge.
Delete unneeded portions of packages.yaml (don't just comment them out), and delete all unneeded environment variable definitions.
NlightNFotis
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the GitHub Actions building CBMC packages.
By the way, the workflow Build and Test Xen also appears to be broken in develop.