Print binary values of floats #5322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thk123
force-pushed
the
print-binary-values-of-floats
branch
from
1e0457c to
38f321c
Compare
thk123
commented
May 1, 2020
| <xs:complexType> | ||
| <xs:simpleContent> | ||
| <xs:extension base="xs:string"> | ||
| <xs:attribute name="binary" type="xs:string"/> |
There was a problem hiding this comment.
⛏️ this could be made more precise using a XSD type where we limit this to be only [01]+
thk123
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
thk123
force-pushed
the
print-binary-values-of-floats
branch
from
38f321c to
98f8882
Compare
Applied modern coding standards to pulled out code Co-authored-by: Peter Schrammel <[email protected]>
This is a precise representation of the floats, which can be useful
Also updat the LaTeX and markdown documentation to include the new attribute
Includes dependencies for builing the xml_spec LaTeX, as well as running the trace through the specification.
The links were not relative, so updated to be relative. Mentioned that you can find more in the readme.
thk123
force-pushed
the
print-binary-values-of-floats
branch
from
5b20585 to
cdb0b78
Compare
|
@peterschrammel comments addressed and squashed |
peterschrammel
approved these changes
May 6, 2020
NlightNFotis
approved these changes
May 6, 2020
| @@ -348,4 +350,3 @@ comes with a small set of definitions, which includes functions such as | |||
|
|
|||
| We also have a [list of interesting applications of | |||
| CBMC](http://www.cprover.org/cbmc/applications/). | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't there be a newline here?
There was a problem hiding this comment.
This was auto-removed on save, because there are two new lines at the end of the file
|
Failure is real - on Windows the complex variable name is prefixed with a _ , I guess this is to do with the name of the variable being reserved on windows so I'll just change the name as not part of the test |
complex is renamed in the trace to _complex on Windows. Therefore adapt the test to use a non-reserved name since not important to the test.
|
clang format was an apt get failure - restared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.