Skip to content

Fix duplicated code #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Fix duplicated code #5319

merged 2 commits into from
Apr 24, 2020

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Apr 23, 2020

Clang tidy highlighted some shadowed variables - looks like a simple case of some copy-pasted code.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [na] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Thomas Kiley added 2 commits April 23, 2020 17:50
lhs_object and symbol were declare and initalized (to the same value)
twice. Looks like a copy-paste error.
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thk123 thk123 merged commit d3f1fc4 into diffblue:develop Apr 24, 2020
@thk123 thk123 deleted the fix-duplicated-code branch April 24, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants