Skip to content

Verify that pointers used in pointer primitives are either null or valid #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Verify that pointers used in pointer primitives are either null or valid #5318

merged 1 commit into from
Apr 23, 2020

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Apr 23, 2020 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

peterschrammel
peterschrammel reviewed Apr 23, 2020
View reviewed changes
src/analyses/goto_check.cpp Outdated
@@ -1860,6 +1935,8 @@ void goto_checkt::goto_check(
flag_resetter.set_flag(enable_undefined_shift_check, false);
else if(d.first == "disable:nan-check")
flag_resetter.set_flag(enable_nan_check, false);
else if(d.first == "disable:pointers-in-assumptions-check")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a different name here?

Suggested change
else if(d.first == "disable:pointers-in-assumptions-check")
else if(d.first == "disable:pointer-primitive-check")

@danpoe danpoe force-pushed the feature/pointer-primitive-check branch 3 times, most recently from dbc9835 to d025257 Compare April 23, 2020 16:37
@danpoe danpoe marked this pull request as ready for review April 23, 2020 16:48
peterschrammel
peterschrammel approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

regression/cbmc/pointer-primitive-check-01/main.c
@@ -0,0 +1,28 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ unnecessary blank line

@danpoe danpoe merged commit 3024404 into diffblue:develop Apr 23, 2020
@danpoe danpoe added the aws Bugs or features of importance to AWS CBMC users label Apr 24, 2020
@danpoe danpoe mentioned this pull request Apr 27, 2020
Closed
@danpoe danpoe deleted the feature/pointer-primitive-check branch June 2, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@smowton smowton Awaiting requested review from smowton

@thk123 thk123 Awaiting requested review from thk123

Assignees
No one assigned
Labels
aws Bugs or features of importance to AWS CBMC users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danpoe @peterschrammel