Skip to content

fix file_rename on Windows #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2020
Merged

fix file_rename on Windows #5261

merged 1 commit into from
Mar 7, 2020

Conversation

kroening
Copy link
Member

@kroening kroening commented Mar 6, 2020

This is a fixup of 98325ce.

ReplaceFile only works when there is a file to replace. MoveFileExW with
MOVEFILE_REPLACE_EXISTING does deliver that. It's not atomic, but there
does not appear to be a sensible way to deliver that on Windows. Boost also
uses MovFileExW.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is a fixup of 98325ce.

ReplaceFile only works when there is a file to replace.  MoveFileExW with
MOVEFILE_REPLACE_EXISTING does deliver that.  It's not atomic, but there
does not appear to be a sensible way to deliver that on Windows.  Boost also
uses MovFileExW.
@kroening kroening merged commit 9ee5b9d into develop Mar 7, 2020
@kroening kroening deleted the file-rename2 branch March 7, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants