Skip to content

Support byte-extracting from unions of non-fixed size #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Various other types (including structs) were handled already, just unions were missing. Treat them much like a single-member struct.

The first commit is #5251, just the second commit is new.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest a test case for the corner no-elements / no-widest-element cases

Avoids duplicate code and enables future re-use.
@tautschnig tautschnig force-pushed the byte-extract-unbounded-union branch from d33a903 to 7ac30d5 Compare March 3, 2020 09:48
Various other types (including structs) were handled already, just
unions were missing. Treat them much like a single-member struct.
@tautschnig tautschnig force-pushed the byte-extract-unbounded-union branch from 7ac30d5 to 645f4e8 Compare March 3, 2020 09:52
@tautschnig
Copy link
Collaborator Author

Suggest a test case for the corner no-elements / no-widest-element cases

Done.

@tautschnig tautschnig changed the title Support byte-extracting from unions of non-fixed size [depends-on: #5251] Support byte-extracting from unions of non-fixed size Mar 3, 2020
@tautschnig tautschnig merged commit 051911e into diffblue:develop Mar 3, 2020
@tautschnig tautschnig deleted the byte-extract-unbounded-union branch March 3, 2020 12:32
@tautschnig tautschnig restored the byte-extract-unbounded-union branch December 27, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants