Add support for gccs __builtin_sub_overflow primitives #5235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-steffenhagen-diffblue
requested review from
chrisr-diffblue,
kroening and
tautschnig
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5235 +/- ##
===========================================
+ Coverage 67.42% 67.42% +<.01%
===========================================
Files 1162 1162
Lines 95606 95606
===========================================
+ Hits 64459 64460 +1
+ Misses 31147 31146 -1
Continue to review full report at Codecov.
|
hannes-steffenhagen-diffblue
force-pushed
the
feature/gcc_overflow_builtins
branch
from
88d98ef to
1249404
Compare
danpoe
approved these changes
Feb 17, 2020
hannes-steffenhagen-diffblue
force-pushed
the
feature/gcc_overflow_builtins
branch
from
1249404 to
0d3f4c9
Compare
Note: Not the generic version
hannes-steffenhagen-diffblue
force-pushed
the
feature/gcc_overflow_builtins
branch
from
0d3f4c9 to
d33d348
Compare
|
|
||
| \[check_int.assertion.1\] line \d+ assertion !__builtin_ssub_overflow\(1, 1, &result\): SUCCESS | ||
| \[check_int.assertion.2\] line \d+ assertion result == 0: SUCCESS | ||
| \[check_int.assertion.3\] line \d+ assertion __builtin_ssub_overflow\(.*, 1, &result\): SUCCESS |
There was a problem hiding this comment.
In case you’re wondering, the regexes here are due cbmc on travis (and apparently only on travis) “helpfully” expanding macros in assertion messages...
chrisr-diffblue
approved these changes
Feb 17, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Not the generic version
More or less the same as #5233, but with
subinstead ofadd.