Make CMake generation of cprover_library.inc match with Makefile #5234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-steffenhagen-diffblue
requested review from
chrisr-diffblue,
kroening and
tautschnig
as code owners
| COMMAND converter < ${converter_input_path} > "${CMAKE_CURRENT_BINARY_DIR}/cprover_library.inc" | ||
| DEPENDS converter ${converter_input_path} | ||
| ) | ||
| COMMAND cat ${ansi_c_library_sources} | $<TARGET_FILE:converter> > "${CMAKE_CURRENT_BINARY_DIR}/cprover_library.inc" |
There was a problem hiding this comment.
Any particular reason for using cat here, rather than just stdin redirection from the file?
There was a problem hiding this comment.
@chrisr-diffblue Because it’s a list of files, not just one.
There was a problem hiding this comment.
Doh, of course.... :-)
chrisr-diffblue
approved these changes
Feb 14, 2020
hannes-steffenhagen-diffblue
force-pushed
the
fix/cmake-ansi-c-library-converter
branch
from
ecab714 to
0c29c8d
Compare
Before it appended the converter input at configure time, meaning if you changed any of the model *.c files it’d actually not notice the change unless you ran CMake again. This version will pick up such changes, and also matches what we have in the current Makefile.
hannes-steffenhagen-diffblue
force-pushed
the
fix/cmake-ansi-c-library-converter
branch
from
0c29c8d to
711b52e
Compare
NlightNFotis
approved these changes
Feb 14, 2020
danpoe
approved these changes
Feb 14, 2020
Codecov Report
@@ Coverage Diff @@
## develop #5234 +/- ##
===========================================
- Coverage 67.42% 31.9% -35.52%
===========================================
Files 1162 910 -252
Lines 95606 79415 -16191
===========================================
- Hits 64459 25336 -39123
- Misses 31147 54079 +22932
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it appended the converter input at configure time, meaning if you changed
any of the model *.c files it’d actually not notice the change unless you ran
CMake again. This version will pick up such changes, and also matches what we
have in the current Makefile.