Misc string cleanup #5232
Merged
Misc string cleanup #5232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2020 10:14
These did not match their implementation names
The variable is used in the declaration of a variable. So there is no need to have the dud usage to suppress warnings about unused variables. Updated comment saying it was unused as well.
thk123
force-pushed
the
misc-string-cleanup
branch
from
e137726 to
c911598
Compare
| @@ -1315,29 +1315,28 @@ code_blockt java_string_library_preprocesst::make_copy_constructor_code( | |||
| const irep_idt &function_id, | |||
| symbol_table_baset &symbol_table) | |||
| { | |||
| // Code for the output | |||
| code_blockt code; | |||
| code_blockt output_code; | |||
There was a problem hiding this comment.
⛏️ Even better, copy_constructor_body.
Makes clear it is what the function produces, and makes the comment explaining it redundant.
thk123
force-pushed
the
misc-string-cleanup
branch
from
c911598 to
786f896
Compare
thk123
requested review from
cesaro,
cristina-david,
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
kroening
approved these changes
Feb 20, 2020
|
@smowton would you mind having a look at this (very short) PR as need code owner. |
smowton
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some trivial tidy up whilst looking at the code.