Skip to content

Update java-models-lib to pull in proper exception behaviour for radix check in Integer.parseInt and friends #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

Update java-models-lib to pull in proper exception behaviour for radix check in Integer.parseInt and friends #5230

merged 1 commit into from
Feb 10, 2020
+1 −1

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Feb 10, 2020

No description provided.

@smowton smowton changed the title Update java-models-lib to latest develop Update java-models-lib to latest master Feb 10, 2020
@chrisr-diffblue
Copy link
Contributor

Is there anything specific that gets pulled in by this submodule bump? Or just a general "keep it tracking develop" bump?

@smowton
Copy link
Contributor Author

smowton commented Feb 10, 2020

Integer.parseInt etc now have proper exception behaviour -- in particular they check that the radix of the number is in range.

@chrisr-diffblue chrisr-diffblue changed the title Update java-models-lib to latest master Update java-models-lib to pull in proper exception behaviour for radix check in Integer.parseInt and friends Feb 10, 2020
chrisr-diffblue
chrisr-diffblue approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming CI passes :-)

@majakusber
Copy link

majakusber commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #5230 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5230   +/-   ##
========================================
  Coverage    67.43%   67.43%           
========================================
  Files         1157     1157           
  Lines        95352    95352           
========================================
  Hits         64302    64302           
  Misses       31050    31050
Flag Coverage Δ
#cproversmt2 42.67% <ø> (ø) ⬆️
#regression 63.96% <ø> (ø) ⬆️
#unit 31.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6680696...aedc320. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #5230 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5230   +/-   ##
========================================
  Coverage    67.43%   67.43%           
========================================
  Files         1157     1157           
  Lines        95352    95352           
========================================
  Hits         64302    64302           
  Misses       31050    31050
Flag Coverage Δ
#cproversmt2 42.67% <ø> (ø) ⬆️
#regression 63.96% <ø> (ø) ⬆️
#unit 31.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6680696...aedc320. Read the comment docs.

@smowton smowton merged commit d99572e into diffblue:develop Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisr-diffblue chrisr-diffblue chrisr-diffblue approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smowton @chrisr-diffblue @majakusber @codecov-io