Improve replace_symbolt precondition message #5219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkhaz
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
karkhaz
force-pushed
the
kk-useful-replace-symbol-assertion
branch
from
2e18e82 to
8e5be0d
Compare
hannes-steffenhagen-diffblue
approved these changes
Jan 31, 2020
src/util/replace_symbol.cpp
Outdated
| old_expr.type() == new_expr.type(), | ||
| "types to be replaced should match.\nold type: '" + | ||
| old_expr.type().pretty() + "'\nnew.type: '" + new_expr.type().pretty() + | ||
| "')"); |
There was a problem hiding this comment.
Suggested change
| "')"); | |
| PRECONDITION_WITH_DIAGNOSTICS( | |
| old_expr.type() == new_expr.type(), | |
| "types to be replaced should match.\nold type: ", old_expr.type(), | |
| "new.type: ", new_expr.type()); |
I’d recommend against the quotes and what not (the output isn’t really machine parseable anyway, and irep outputs are almost always going to be multiline so the quotes don’t really help with human readability either), and anything that has a specialisation for diagnostics_helpert (ireps do), can just be added as an argument and the macro takes care of the concatenation.
kroening
approved these changes
Feb 1, 2020
martin-cs
approved these changes
Feb 6, 2020
karkhaz
force-pushed
the
kk-useful-replace-symbol-assertion
branch
2 times, most recently
from
9f9a16c to
8649e1e
Compare
Invariant violations now print out the actual types that were mismatched.
karkhaz
force-pushed
the
kk-useful-replace-symbol-assertion
branch
from
8649e1e to
52001fa
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5219 +/- ##
========================================
Coverage 67.43% 67.43%
========================================
Files 1157 1157
Lines 95352 95352
========================================
Hits 64302 64302
Misses 31050 31050
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invariant violations now print out the actual types that were mismatched.