Clean Const Function Pointer Removal

regression/goto-analyzer/approx-array-variable-const-fp/main.c

@@ -0,0 +1,34 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+const void_fp fp_tbl[] = {f2, f3 ,f4};
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func(int i)
+{
+  fp_tbl[i]();
+}
+
+int main()
+{
+  for(int i=0;i<3;i++)
+  {
+    func(i);
+  }
+
+  return 0;
+}

regression/goto-analyzer/approx-array-variable-const-fp/test.desc

@@ -0,0 +1,17 @@
+CORE
+main.c
+--show-goto-functions --verbosity 10 --pointer-check
+
+^Removing function pointers and virtual functions$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f2 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f3 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f4 THEN GOTO [0-9]$
+^SIGNAL=0$
+--
+^\s*IF fp_tbl\[\(signed long int\)i\] == f1 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f5 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f6 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f7 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f8 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f9 THEN GOTO [0-9]$
+^warning: ignoring

regression/goto-analyzer/approx-const-fp-array-variable-cast-const-fp/main.c

@@ -0,0 +1,41 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void(* const fp_tbl[3])(void) =
+{
+  (void(*)())f2,
+  (void(*)())f3,
+  (void(*)())f4,
+};
+
+
+void func(int i)
+{
+  const void_fp fp = fp_tbl[i];
+  fp();
+}
+
+int main()
+{
+  for(int i=0;i<3;i++)
+  {
+    func(i);
+  }
+
+  return 0;
+}

regression/goto-analyzer/approx-const-fp-array-variable-cast-const-fp/test.desc

@@ -0,0 +1,17 @@
+CORE
+main.c
+--show-goto-functions --verbosity 10 --pointer-check
+
+^Removing function pointers and virtual functions$
+^\s*IF fp == f2 THEN GOTO [0-9]$
+^\s*IF fp == f3 THEN GOTO [0-9]$
+^\s*IF fp == f4 THEN GOTO [0-9]$
+^SIGNAL=0$
+--
+^warning: ignoring
+^\s*IF fp_tbl\[\(signed long int\)i\] == f1 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f5 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f6 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f7 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f8 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f9 THEN GOTO [0-9]$

regression/goto-analyzer/approx-const-fp-array-variable-const-fp-with-null/main.c

@@ -0,0 +1,35 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+const void_fp fp_tbl[] = {f2, f3 ,f4, 0};
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func(int i)
+{
+  const void_fp fp = fp_tbl[i];
+  fp();
+}
+
+int main()
+{
+  for(int i=0;i<3;i++)
+  {
+    func(i);
+  }
+
+  return 0;
+}

regression/goto-analyzer/approx-const-fp-array-variable-const-fp-with-null/test.desc

@@ -0,0 +1,17 @@
+CORE
+main.c
+--show-goto-functions --verbosity 10 --pointer-check
+
+^Removing function pointers and virtual functions$
+^\s*IF fp == f2 THEN GOTO [0-9]$
+^\s*IF fp == f3 THEN GOTO [0-9]$
+^\s*IF fp == f4 THEN GOTO [0-9]$
+^SIGNAL=0$
+--
+^warning: ignoring
+^\s*IF fp_tbl\[\(signed long int\)i\] == f1 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f5 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f6 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f7 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f8 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f9 THEN GOTO [0-9]$

regression/goto-analyzer/approx-const-fp-array-variable-const-fp/main.c

@@ -0,0 +1,35 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+const void_fp fp_tbl[] = {f2, f3 ,f4};
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func(int i)
+{
+  const void_fp fp = fp_tbl[i];
+  fp();
+}
+
+int main()
+{
+  for(int i=0;i<3;i++)
+  {
+    func(i);
+  }
+
+  return 0;
+}

regression/goto-analyzer/approx-const-fp-array-variable-const-fp/test.desc

@@ -0,0 +1,17 @@
+CORE
+main.c
+--show-goto-functions --verbosity 10 --pointer-check
+
+^Removing function pointers and virtual functions$
+^\s*IF fp == f2 THEN GOTO [0-9]$
+^\s*IF fp == f3 THEN GOTO [0-9]$
+^\s*IF fp == f4 THEN GOTO [0-9]$
+^SIGNAL=0$
+--
+^warning: ignoring
+^\s*IF fp_tbl\[\(signed long int\)i\] == f1 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f5 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f6 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f7 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f8 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f9 THEN GOTO [0-9]$

regression/goto-analyzer/approx-const-fp-array-variable-const-pointer-const-struct-non-const-fp/main.c

@@ -0,0 +1,50 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+struct action
+{
+  void_fp fun;
+};
+
+const struct action rec = { .fun = f2 };
+const struct action rec2 = { .fun = f3 };
+const struct action rec3 = { .fun = f4 };
+
+const struct action * const action_list[4] =
+{
+  &rec,
+  &rec2,
+  &rec3,
+  &rec
+};
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func(int i)
+{
+  const void_fp fp = action_list[i]->fun;
+  fp();
+}
+
+int main()
+{
+  for(int i=0;i<3;i++)
+  {
+    func(i);
+  }
+
+  return 0;
+}

regression/goto-analyzer/approx-const-fp-array-variable-const-pointer-const-struct-non-const-fp/test.desc

@@ -0,0 +1,17 @@
+CORE
+main.c
+--show-goto-functions --verbosity 10 --pointer-check
+
+^Removing function pointers and virtual functions$
+^\s*IF fp == f2 THEN GOTO [0-9]$
+^\s*IF fp == f3 THEN GOTO [0-9]$
+^\s*IF fp == f4 THEN GOTO [0-9]$
+^SIGNAL=0$
+--
+^warning: ignoring
+^\s*IF fp_tbl\[\(signed long int\)i\] == f1 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f5 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f6 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f7 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f8 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f9 THEN GOTO [0-9]$

regression/goto-analyzer/approx-const-fp-array-variable-const-struct-non-const-fp/main.c

@@ -0,0 +1,51 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+struct stable
+{
+  int x;
+  void (*fp)(void);
+};
+
+const struct stable stable_table [3] =
+{
+  { 1, f2 },
+  { 2, f3 },
+  { 3, f4 }
+};
+
+const struct stable another_table = { 4, f5 };
+
+
+void func(int i)
+{
+  const void_fp fp = stable_table[i].fp;
+
+  // Illegal
+  // stable_table[1] = another_table;
+  fp();
+}
+
+int main()
+{
+  for(int i=0;i<3;i++)
+  {
+    func(i);
+  }
+  return 0;
+}

regression/goto-analyzer/approx-const-fp-array-variable-const-struct-non-const-fp/test.desc

@@ -0,0 +1,17 @@
+CORE
+main.c
+--show-goto-functions --verbosity 10 --pointer-check
+
+^Removing function pointers and virtual functions$
+^\s*IF fp == f2 THEN GOTO [0-9]$
+^\s*IF fp == f3 THEN GOTO [0-9]$
+^\s*IF fp == f4 THEN GOTO [0-9]$
+^SIGNAL=0$
+--
+^warning: ignoring
+^\s*IF fp_tbl\[\(signed long int\)i\] == f1 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f5 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f6 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f7 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f8 THEN GOTO [0-9]$
+^\s*IF fp_tbl\[\(signed long int\)i\] == f9 THEN GOTO [0-9]$