[TG-9313] Fix invariant failure in case of negative size arrays #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to make an invariant fail when the input array had negative size.
If the specified array size is negative just do as if it was 0, this is similar to the case where the array size is not given.
This tests that defining an array with negative size does not make JBMC crash.
romainbrenguier
requested review from
kroening,
martin-cs,
peterschrammel,
smowton and
tautschnig
as code owners
romainbrenguier
force-pushed
the
bugfix/negative-size-arrays
branch
from
1e89721 to
4259db2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5128 +/- ##
========================================
Coverage 66.97% 66.97%
========================================
Files 1146 1146
Lines 93736 93736
========================================
Hits 62778 62778
Misses 30958 30958
Continue to review full report at Codecov.
|
allredj
reviewed
Sep 25, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4259db2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/129092419
smowton
approved these changes
Sep 25, 2019
peterschrammel
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes JBMC resilient to arrays declared with negative size.
Note that this wouldn't be a problem with
--throw-runtime-exceptionsas the declaration would be followed by athrow.