Remove unneeded class hierarchy from resolve_inherited_componentt #5118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc-diffblue
requested review from
cesaro,
cristina-david,
kroening,
NathanJPhillips,
peterschrammel,
pkesseli,
tautschnig and
thk123
as code owners
owen-mc-diffblue
force-pushed
the
remove-unneeded-class-hierarchy-from-resolve-inherited-componentt
branch
from
d178bfc to
57bd05e
Compare
allredj
reviewed
Sep 19, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 57bd05e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/128288014
romainbrenguier
approved these changes
Sep 19, 2019
| const std::vector<irep_idt> parents = | ||
| make_range(to_struct_type(current_class_symbol_it->second.type).bases()) | ||
| .map([](const struct_typet::baset &base) { | ||
| return base.type().get_identifier(); |
There was a problem hiding this comment.
💡 the vector is not strictly necessary here, you could have used auto to have it as a range instead
owen-mc-diffblue
force-pushed
the
remove-unneeded-class-hierarchy-from-resolve-inherited-componentt
branch
from
57bd05e to
3600f70
Compare
thk123
approved these changes
Sep 19, 2019
This means it can be used even in settings where a class hierarchy isn't readily available. The class hierarchy was only being used to find parents, which are easily available from the class type directly, so it wasn't providing any benefit. (It would have been different if we needed to find children.)
owen-mc-diffblue
force-pushed
the
remove-unneeded-class-hierarchy-from-resolve-inherited-componentt
branch
from
3600f70 to
0c9a5bc
Compare
7 tasks
allredj
reviewed
Sep 19, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 0c9a5bc).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/128332467
Codecov Report
@@ Coverage Diff @@
## develop #5118 +/- ##
===========================================
+ Coverage 69.71% 69.71% +<.01%
===========================================
Files 1322 1322
Lines 109429 109432 +3
===========================================
+ Hits 76287 76290 +3
Misses 33142 33142
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
Sep 19, 2019
owen-mc-diffblue
deleted the
remove-unneeded-class-hierarchy-from-resolve-inherited-componentt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means it can be used even in settings where a class hierarchy isn't
readily available. The class hierarchy was only being used to find
parents, which are easily available from the class type directly, so it
wasn't providing any benefit. (It would have been different if we needed
to find children.)