Skip to content

Add docs for --export-file-local-symbols #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

karkhaz
Copy link
Collaborator

@karkhaz karkhaz commented Sep 16, 2019

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: d8a5669).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/127878303

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #5111 into develop will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5111      +/-   ##
===========================================
- Coverage    67.41%   67.41%   -0.01%     
===========================================
  Files         1157     1157              
  Lines        95268    95271       +3     
===========================================
+ Hits         64225    64227       +2     
- Misses       31043    31044       +1
Flag Coverage Δ
#cproversmt2 42.67% <ø> (ø) ⬆️
#regression 63.93% <75%> (ø) ⬆️
#unit 31.95% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/goto-cc/ms_cl_cmdline.cpp 0% <ø> (ø) ⬆️
src/goto-cc/gcc_cmdline.cpp 74.48% <ø> (ø) ⬆️
src/goto-cc/compile.cpp 67.87% <75%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbac963...a3a7edb. Read the comment docs.

@karkhaz karkhaz force-pushed the kk-static-documentation branch 3 times, most recently from 87c87cb to 6b42edd Compare February 10, 2020 20:22
@karkhaz karkhaz changed the title Add docs for --export-function-local-symbols Add docs for --export-file-local-symbols Feb 10, 2020
@karkhaz
Copy link
Collaborator Author

karkhaz commented Feb 10, 2020

@smowton I addressed all comments and made some extra changes to make the naming consistent. Thanks.

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for catching this inconsitency and cleaning it up - and double thanks for the high quality docs to go with it. 👍

@karkhaz karkhaz force-pushed the kk-static-documentation branch from 6b42edd to 2ffa912 Compare February 11, 2020 15:13
@karkhaz karkhaz force-pushed the kk-static-documentation branch from 2ffa912 to 992865d Compare February 11, 2020 15:14
@karkhaz karkhaz force-pushed the kk-static-documentation branch from 992865d to a3a7edb Compare February 11, 2020 15:19
@karkhaz karkhaz merged commit 86d36f6 into diffblue:develop Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants