Skip to content

Tests for constant propagation of string constructors #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2019
Merged

Tests for constant propagation of string constructors #5110

merged 4 commits into from
Sep 23, 2019

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Sep 16, 2019 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@danpoe
Rename default constructor constant evaluation regression tests
42c19fb 
Rename the directories to follow the existing naming convention
@danpoe danpoe force-pushed the feature/string-constructors branch 2 times, most recently from a129de3 to b40e637 Compare September 16, 2019 13:42
@danpoe
Add entry for StringBuilder constructors to the string preprocessing
85cfa30 
Add entries for StringBuilder(CharSequence) and StringBuilder(int capacity) to
the string library preprocessing
@danpoe
Adjust data invariant for constant propagation of the empty string
b88b015 
Require >= 2 arguments instead of 2 arguments. This enables the modelling of
methods that result in the empty string but take arguments that are ignored.
@danpoe
Add tests for the constant propagation of String and StringBuilder co…
b40e637 
…nstructors

Add regression tests that test the constructors that take string types or
primitive types.
@codecov-io
Copy link

Codecov Report

Merging #5110 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5110      +/-   ##
===========================================
+ Coverage    69.71%   69.71%   +<.01%     
===========================================
  Files         1322     1322              
  Lines       109429   109432       +3     
===========================================
+ Hits         76287    76290       +3     
  Misses       33142    33142
Impacted Files Coverage Δ
src/goto-symex/goto_symex.cpp 99.44% <ø> (ø) ⬆️
...c/java_bytecode/java_string_library_preprocess.cpp 96.83% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74a8d8...b40e637. Read the comment docs.

allredj
allredj reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: b40e637).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/127818598

@danpoe danpoe merged commit 23e8572 into diffblue:develop Sep 23, 2019
@danpoe danpoe deleted the feature/string-constructors branch June 2, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@JohnDumbell JohnDumbell JohnDumbell approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

@thk123 thk123 Awaiting requested review from thk123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danpoe @codecov-io @smowton @allredj @JohnDumbell