Skip to content

Use type_try_dynamic_cast in particular case where it clarifies the code #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

NathanJPhillips
Copy link
Contributor

  • Each commit message has a non-empty body, explaining why the change was made.
  • N/A Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • N/A The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • N/A My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • N/A White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #5088 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5088   +/-   ##
========================================
  Coverage    69.66%   69.66%           
========================================
  Files         1319     1319           
  Lines       109234   109234           
========================================
  Hits         76102    76102           
  Misses       33132    33132
Impacted Files Coverage Δ
jbmc/src/java_bytecode/java_types.cpp 96.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7646df...35fb893. Read the comment docs.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 35fb893).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/126036077

@NathanJPhillips NathanJPhillips merged commit fc0a0cd into develop Sep 5, 2019
@NathanJPhillips NathanJPhillips deleted the cleanup/use-try-cast branch September 5, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants